-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
429 save cdm database name #430
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #430 +/- ##
===========================================
+ Coverage 89.32% 89.44% +0.12%
===========================================
Files 49 49
Lines 9830 9838 +8
===========================================
+ Hits 8781 8800 +19
+ Misses 1049 1038 -11 ☔ View full report in Codecov by Sentry. |
@jreps this should be now ready for review. I've also tested it locally by fitting two models and viewing them in the shiny since I was worried this might affect that. I had to make a few other changes to get the tests to pass. Was dealing with some strange test failures that only happened during code coverage in github actions.
|
* Update DESCRIPTION * only resrtict to first if many observations per subjectId * fix assignment operator in configurePython (#421) * Tibble dependancy removal (#422) * remove unnecessary remotes (#423) * Study population improvements (#424) * assign population if existing and added a test (#428) * 429 save cdm database name (#430) * save dev database name and schema in trainDetails (#434) * preserve attributes when splitting data * Prevent plpData from being evaluated during do.call (#436) * test improvements (#438) * fix duplicate vignette titles --------- Co-authored-by: jreps <[email protected]> Co-authored-by: Henrik <[email protected]>
Fixes #429