Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate external improvements #485

Open
wants to merge 31 commits into
base: develop
Choose a base branch
from

Conversation

egillax
Copy link
Collaborator

@egillax egillax commented Oct 11, 2024

  • Add logging for population creation
  • Error when validating and outcomes are <10
  • create downloadTasks list from unique combinations of restrictPlpDataSettings and targetId to avoid downloading the same thing multiple times

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 85.10638% with 14 lines in your changes missing coverage. Please review.

Project coverage is 86.98%. Comparing base (5f53965) to head (2ab8d7c).

Files with missing lines Patch % Lines
R/ExternalValidatePlp.R 84.61% 14 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #485      +/-   ##
===========================================
+ Coverage    86.09%   86.98%   +0.88%     
===========================================
  Files           50       50              
  Lines        10286    10369      +83     
===========================================
+ Hits          8856     9019     +163     
+ Misses        1430     1350      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant