add (expandedWidth, borderSize, collapsedWidth) parameters to the sidePanel component #3606

Sofien-Sellami · 2023-08-16T17:36:44Z

Context

I've made these changes to give the option of changing the sidepanel parameters (expandedWidth, borderSize, collapsedWidth)

Changes & Results

in this example I've expanded the width of the sidePanel
<SidePanel expandedWidth={500} side="right" activeTabIndex={rightPanelDefaultClosed ? null : 0} tabs={rightPanelComponents} servicesManager={servicesManager} />

Testing

Checklist

PR

My Pull Request title is descriptive, accurate and follows the
semantic-release format and guidelines.

Code

My code has been well-documented (function documentation, inline comments,
etc.)

Public Documentation Updates

The documentation page has been updated as necessary for any public API
additions or removals.

Tested Environment

OS:
Node version:
Browser:

…ePanel component

netlify · 2023-08-16T17:36:50Z

✅ Deploy Preview for ohif-platform-docs ready!

Name	Link
🔨 Latest commit	`6723d39`
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-platform-docs/deploys/652e913f25ef2e0008a5838c
😎 Deploy Preview	https://deploy-preview-3606--ohif-platform-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-08-16T17:36:50Z

✅ Deploy Preview for ohif-dev canceled.

Name	Link
🔨 Latest commit	`6723d39`
🔍 Latest deploy log	https://app.netlify.com/sites/ohif-dev/deploys/652e913ffcec860008e7818b

codecov · 2023-08-16T17:42:45Z

Codecov Report

Merging #3606 (6723d39) into master (8a335bd) will decrease coverage by 0.15%.
Report is 69 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #3606      +/-   ##
==========================================
- Coverage   46.23%   46.09%   -0.15%     
==========================================
  Files          78       78              
  Lines        1276     1280       +4     
  Branches      312      312              
==========================================
  Hits          590      590              
- Misses        548      552       +4     
  Partials      138      138

Files	Coverage Δ
platform/core/src/utils/downloadCSVReport.js	`0.00% <ø> (ø)`
...ils/metadataProvider/getPixelSpacingInformation.js	`0.00% <0.00%> (ø)`
platform/core/src/log.js	`14.28% <0.00%> (-85.72%)`	⬇️
...services/DicomMetadataStore/createStudyMetadata.js	`0.00% <0.00%> (ø)`
...ervices/DicomMetadataStore/createSeriesMetadata.js	`0.00% <0.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f1259...6723d39. Read the comment docs.

sedghi · 2023-10-03T15:49:12Z

Sorry for my late response, but can you please update this based on the new side panel?

…#3604)

OHIF#3611)

…ata source with Google cloud healthcare implementation (OHIF#3589)

…data (OHIF#3621)

…r a data source is not fully configured (OHIF#3620)

Co-authored-by: Bill Wallace <[email protected]>

…HIF#3695) Co-authored-by: Ahmet Altay <[email protected]>

Co-authored-by: pwespi <[email protected]>

…and microscopy side panel (OHIF#3696)

sedghi · 2023-10-05T15:59:55Z

git pull origin master --no-rebase
and solve the conflicts

jbocce · 2023-10-17T12:43:08Z

platform/ui/src/components/SidePanel/SidePanel.tsx

-              position={side === 'left' ? 'right' : 'left'}
-              key={index}
-              content={`${childComponent.label}`}
+        <>


I see a lot of places like this where the indentation changed and I am not sure why. Could you please fix this?

jbocce

Good change! Thanks!

See my one comment.

jbocce · 2023-10-17T12:55:40Z

Hmmm... the title of the PR says that also borderSize and collapsedWidth can be changed. I do not see those props. I am happy with just changing the expandedWidth for now if that is ok or are you planning on making more changes?

Sofien-Sellami · 2023-10-17T13:51:29Z

Hmmm... the title of the PR says that also borderSize and collapsedWidth can be changed. I do not see those props. I am happy with just changing the expandedWidth for now if that is ok or are you planning on making more changes?

hi @jbocce, I fixed the stuff you asked for, and I don't think I'm going to add the bordersize and collapsedWidth props because I think they need to be fixed.

jbocce · 2023-10-17T15:55:12Z

Hmmm... the title of the PR says that also borderSize and collapsedWidth can be changed. I do not see those props. I am happy with just changing the expandedWidth for now if that is ok or are you planning on making more changes?

hi @jbocce, I fixed the stuff you asked for, and I don't think I'm going to add the bordersize and collapsedWidth props because I think they need to be fixed.

That makes sense and is my preference too.

jbocce

Approved. Thanks again!

sedghi · 2023-10-17T15:57:55Z

@Sofien-Sellami please git pull origin master --no-rebase and resolve conflicts and push again

Sofien-Sellami · 2023-10-17T16:22:07Z

@Sofien-Sellami please git pull origin master --no-rebase and resolve conflicts and push again

HI @sedghi, there is no change

sedghi · 2023-10-17T16:31:52Z

sorry you origin is your fork, so git pull upstream? what ever you are calling it

git remote -v

add (expandedWidth, borderSize, collapsedWidth) parameters to the sid…

bc8ddaf

…ePanel component

ohif-bot and others added 25 commits October 5, 2023 15:18

chore(version): version.json [skip ci]

5898e52

chore(version): Update package versions [skip ci]

159c375

fix(rgb): Fix rgb inconsistencies by updating cs3d image loader (OHIF…

b75a3d4

…#3604)

chore(version): version.json [skip ci]

a6a43b8

chore(version): Update package versions [skip ci]

002273f

fix(memory leak): array buffer was sticking around in volume viewports (

6b8b959

OHIF#3611)

chore(version): version.json [skip ci]

676da4f

chore(version): Update package versions [skip ci]

b4063f5

feat(cloud data source config): GUI and API for configuring a cloud d…

a7bc562

…ata source with Google cloud healthcare implementation (OHIF#3589)

chore(version): version.json [skip ci]

ac9f990

chore(version): Update package versions [skip ci]

8510eca

fi(buffer): buffer undefined (OHIF#3590)

382e831

chore(version): version.json [skip ci]

4b5406f

chore(version): Update package versions [skip ci]

591f2ba

fix(PT Metadata): Allow for PatientWeight to be missing from the meta…

83fc584

…data (OHIF#3621)

chore(version): version.json [skip ci]

b77490f

chore(version): Update package versions [skip ci]

4ad52a4

fix(OpenIdConnectRoutes): fix handleUnauthenticated (OHIF#3617)

c4779e2

chore(version): version.json [skip ci]

c0fce48

chore(version): Update package versions [skip ci]

394a1f6

feat(data source UI config): Popup the configuration dialogue wheneve…

97931c4

…r a data source is not fully configured (OHIF#3620)

chore(version): version.json [skip ci]

0e0790c

chore(version): Update package versions [skip ci]

4fc99d3

feat(grid): remove viewportIndex and only rely on viewportId (OHIF#3591)

9970df3

Co-authored-by: Bill Wallace <[email protected]>

chore(version): version.json [skip ci]

93ed77b

ohif-bot and others added 14 commits October 5, 2023 15:20

chore(version): Update package versions [skip ci]

1d60027

fix(translation): Side panel translate fix (OHIF#3156)

b481b13

chore(version): version.json [skip ci]

a902bb1

chore(version): Update package versions [skip ci]

167196b

feat(locale): Added Turkish language support (tr-TR) - Community PR (O…

ef2200c

…HIF#3695) Co-authored-by: Ahmet Altay <[email protected]>

chore(version): version.json [skip ci]

1f8b667

chore(version): Update package versions [skip ci]

e63e3d0

feat(locale): add German translations - community PR (OHIF#3697)

12b004e

Co-authored-by: pwespi <[email protected]>

chore(version): version.json [skip ci]

0ee13aa

chore(version): Update package versions [skip ci]

ca1b7ee

fix(measurement and microscopy): various small fixes for measurement …

251f03b

…and microscopy side panel (OHIF#3696)

chore(version): version.json [skip ci]

20f0539

chore(version): Update package versions [skip ci]

433f83a

update commit based on the new side panel

b17ef6f

resolve conflicts

485e425

sedghi requested a review from jbocce October 17, 2023 02:23

jbocce reviewed Oct 17, 2023

View reviewed changes

Sofien-Sellami added 3 commits October 17, 2023 14:37

fix

bde7467

fix

7959f1e

fix

6723d39

jbocce approved these changes Oct 17, 2023

View reviewed changes

Sofien-Sellami closed this Dec 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add (expandedWidth, borderSize, collapsedWidth) parameters to the sidePanel component #3606

add (expandedWidth, borderSize, collapsedWidth) parameters to the sidePanel component #3606

Sofien-Sellami commented Aug 16, 2023

netlify bot commented Aug 16, 2023 •

edited

Loading

netlify bot commented Aug 16, 2023 •

edited

Loading

codecov bot commented Aug 16, 2023 •

edited

Loading

sedghi commented Oct 3, 2023

sedghi commented Oct 5, 2023

jbocce Oct 17, 2023

jbocce left a comment

jbocce commented Oct 17, 2023

Sofien-Sellami commented Oct 17, 2023

jbocce commented Oct 17, 2023

jbocce left a comment

sedghi commented Oct 17, 2023

Sofien-Sellami commented Oct 17, 2023

sedghi commented Oct 17, 2023

add (expandedWidth, borderSize, collapsedWidth) parameters to the sidePanel component #3606

add (expandedWidth, borderSize, collapsedWidth) parameters to the sidePanel component #3606

Conversation

Sofien-Sellami commented Aug 16, 2023

Context

Changes & Results

Testing

Checklist

PR

Code

Public Documentation Updates

Tested Environment

netlify bot commented Aug 16, 2023 • edited Loading

✅ Deploy Preview for ohif-platform-docs ready!

netlify bot commented Aug 16, 2023 • edited Loading

✅ Deploy Preview for ohif-dev canceled.

codecov bot commented Aug 16, 2023 • edited Loading

Codecov Report

sedghi commented Oct 3, 2023

sedghi commented Oct 5, 2023

jbocce Oct 17, 2023

Choose a reason for hiding this comment

jbocce left a comment

Choose a reason for hiding this comment

jbocce commented Oct 17, 2023

Sofien-Sellami commented Oct 17, 2023

jbocce commented Oct 17, 2023

jbocce left a comment

Choose a reason for hiding this comment

sedghi commented Oct 17, 2023

Sofien-Sellami commented Oct 17, 2023

sedghi commented Oct 17, 2023

netlify bot commented Aug 16, 2023 •

edited

Loading

netlify bot commented Aug 16, 2023 •

edited

Loading

codecov bot commented Aug 16, 2023 •

edited

Loading