Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 1:1 scale hanging protocol #3639

Closed
wants to merge 3 commits into from
Closed

Conversation

wayfarer3130
Copy link
Contributor

@wayfarer3130 wayfarer3130 commented Sep 8, 2023

This feature adds the display area setting to the hanging protocol, and then uses it to create a 1:1 scale hanging protocol.

This needs PR cornerstonejs/cornerstone3D#755 to be set as the CS3D version for core, but
is otherwise ready to go.

Context

Having a 1:1 scale hanging protocol allows testing/viewing of images without scaling, which allows testing of the rendering position.

Changes & Results

Change the thumbnail to use the new rendering options to set the thumbnail size
Add hpScale as a hanging protocol
Add automated tests for image consistency/comparison

Testing

Display the e2e test environment pages for the TG-18 resolution or general purpose tests with the hangingProtocolId=@ohif/hpScale
You should be able to see the vertical and horizontal bars on the test pattern

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@wayfarer3130 wayfarer3130 requested a review from sedghi September 8, 2023 17:44
@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit a07ae5d
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/650da8bdda76630008ded066
😎 Deploy Preview https://deploy-preview-3639--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 8, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit a07ae5d
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/650da8bd47a6d10008372fbd
😎 Deploy Preview https://deploy-preview-3639--ohif-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #3639 (a07ae5d) into master (48bbd62) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3639   +/-   ##
=======================================
  Coverage   46.23%   46.23%           
=======================================
  Files          78       78           
  Lines        1276     1276           
  Branches      312      312           
=======================================
  Hits          590      590           
  Misses        548      548           
  Partials      138      138           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48bbd62...a07ae5d. Read the comment docs.

@cypress
Copy link

cypress bot commented Sep 8, 2023

4 failed tests on run #3557 ↗︎

4 36 0 0 Flakiness 0

Details:

Merge remote-tracking branch 'ohif/master' into feat/scale-size-hp
Project: Viewers Commit: a07ae5d5f6
Status: Failed Duration: 06:02 💡
Started: Sep 22, 2023 2:53 PM Ended: Sep 22, 2023 2:59 PM
Failed  ImageConsistency.spec.js • 3 failed tests

View Output Video

Test Artifacts
CS3D Image Consistency and Quality > TG18 Resolution Test Displayed 1:1 Test Replay Output Screenshots Video
CS3D Image Consistency and Quality > 8 bit image displayable Test Replay Output Screenshots Video
CS3D Image Consistency and Quality > 12 bit image displayable and zoom with pixel spacing Test Replay Output Screenshots Video
Failed  measurement-tracking/OHIFStudyBrowser.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Study Viewer Page > drags and drop a series thumbnail into viewport Test Replay Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@francomotta
Copy link

Hi @wayfarer3130 ,

I test your code and show a message error when try open a study.

@wayfarer3130
Copy link
Contributor Author

@francomotta - you need to link the appropriate CS3D build into it as there are changes in the stack viewport that are required to make this work.

@francomotta
Copy link

@francomotta - you need to link the appropriate CS3D build into it as there are changes in the stack viewport that are required to make this work.

hi, how I can do this?

@wayfarer3130
Copy link
Contributor Author

@francomotta - I will link the required changes into this issue once we have official builds. Otherwise, you need to folllow the OHIF instructions on how to link in CS3D

@francomotta
Copy link

@francomotta - I will link the required changes into this issue once we have official builds. Otherwise, you need to folllow the OHIF instructions on how to link in CS3D

I'm new and trying to understand the project structure. Can you help me ? I realize that few people have the desire to help. the vast majority ignore the mentions, basic errors. I have a post-processing workstation and I'm thinking about converting some plugins to OHIF. (fusion, perfusion, CTA, QCA).

@wayfarer3130
Copy link
Contributor Author

@francomotta - you should be able to pull the current version now and test it.

@wayfarer3130
Copy link
Contributor Author

@francomotta - actually, realized the CS3D is still not committed.

@wayfarer3130 wayfarer3130 changed the title feat: Add 1:1 scale hanging protocol (WIP: Requires CS3D PR) feat: Add 1:1 scale hanging protocol Mar 22, 2024
@wayfarer3130
Copy link
Contributor Author

This is subsumed by the mammo hanging protocols PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants