-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add 1:1 scale hanging protocol #3639
Conversation
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #3639 +/- ##
=======================================
Coverage 46.23% 46.23%
=======================================
Files 78 78
Lines 1276 1276
Branches 312 312
=======================================
Hits 590 590
Misses 548 548
Partials 138 138 Continue to review full report in Codecov by Sentry.
|
4 failed tests on run #3557 ↗︎
Details:
ImageConsistency.spec.js • 3 failed testsmeasurement-tracking/OHIFStudyBrowser.spec.js • 1 failed test
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Hi @wayfarer3130 , I test your code and show a message error when try open a study. |
@francomotta - you need to link the appropriate CS3D build into it as there are changes in the stack viewport that are required to make this work. |
|
@francomotta - I will link the required changes into this issue once we have official builds. Otherwise, you need to folllow the OHIF instructions on how to link in CS3D |
I'm new and trying to understand the project structure. Can you help me ? I realize that few people have the desire to help. the vast majority ignore the mentions, basic errors. I have a post-processing workstation and I'm thinking about converting some plugins to OHIF. (fusion, perfusion, CTA, QCA). |
@francomotta - you should be able to pull the current version now and test it. |
@francomotta - actually, realized the CS3D is still not committed. |
This is subsumed by the mammo hanging protocols PR |
This feature adds the display area setting to the hanging protocol, and then uses it to create a 1:1 scale hanging protocol.
This needs PR cornerstonejs/cornerstone3D#755 to be set as the CS3D version for core, but
is otherwise ready to go.
Context
Having a 1:1 scale hanging protocol allows testing/viewing of images without scaling, which allows testing of the rendering position.
Changes & Results
Change the thumbnail to use the new rendering options to set the thumbnail size
Add hpScale as a hanging protocol
Add automated tests for image consistency/comparison
Testing
Display the e2e test environment pages for the TG-18 resolution or general purpose tests with the hangingProtocolId=@ohif/hpScale
You should be able to see the vertical and horizontal bars on the test pattern
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment