Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(StackSync): Miscellaneous fixes for stack image sync #3663
fix(StackSync): Miscellaneous fixes for stack image sync #3663
Changes from 20 commits
71b4827
c7ae0d5
270c93f
78022dd
ff63b93
479ca55
091034c
466545c
355670c
c50a9c1
96edc5a
c545b89
62bb7bf
e1869f9
0d10b6d
2dce538
94a0887
7666b93
32ddcc2
c42aefa
f4a5f01
6a0470a
2e8e899
480a147
15cc74e
29f799c
1948368
46dc64c
7ff1bba
78caf6b
c88dc96
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now that you removed
calculateViewportRegistrations
who is handling that?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handled by the CS3D tool library - that way there is exactly one spot to do the calculations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I haven't removed calculateViewportRegistrations because it is needed for another use case which we don't yet support, allowing one to adjust hte registrations.