Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

candidate 3p7 rc 2 #3712

Closed
wants to merge 362 commits into from
Closed

candidate 3p7 rc 2 #3712

wants to merge 362 commits into from

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Oct 10, 2023

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

ohif-bot and others added 30 commits July 7, 2023 15:37
…rnerstone3d instead of calculating the modality unit (again) here. (#3533)
ohif-bot and others added 25 commits October 6, 2023 02:22
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for ohif-prod ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/ohif-prod/deploys/65269de979509c6154acbc26
😎 Deploy Preview https://deploy-preview-3712--ohif-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release@72ec0bf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             release    #3712   +/-   ##
==========================================
  Coverage           ?   46.09%           
==========================================
  Files              ?       78           
  Lines              ?     1280           
  Branches           ?      312           
==========================================
  Hits               ?      590           
  Misses             ?      552           
  Partials           ?      138           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72ec0bf...32905b4. Read the comment docs.

@cypress
Copy link

cypress bot commented Oct 10, 2023

1 failed test on run #3623 ↗︎

1 38 0 0 Flakiness 0

Details:

Merge branch 'release' of github.com:OHIF/Viewers into candidate-3p7-rc-2
Project: Viewers Commit: 32905b41da
Status: Failed Duration: 05:54 💡
Started: Oct 10, 2023 8:07 PM Ended: Oct 10, 2023 8:13 PM
Failed  cypress/integration/measurement-tracking/OHIFStudyBrowser.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Study Browser > drags and drop a series thumbnail into viewport Test Replay Output Screenshots Video

Review all test suite changes for PR #3712 ↗︎

@sedghi sedghi closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.