Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP feat(SR): Add the ability to filter SRs based on selected displaySet #3713

Conversation

rodrigobasilio2022
Copy link
Collaborator

Context

When an study has many SRs, some users prefer that only the SRs of the currently selected displyaSet are shown. This PR adds the ability to filter SRs based on active viewport display set

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit e2fdfd5
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6583093d3b7af0000803b4d0
😎 Deploy Preview https://deploy-preview-3713--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit e2fdfd5
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6583093db3bf360008713bb0

@rodrigobasilio2022 rodrigobasilio2022 added the IDC:priority Items that the Imaging Data Commons wants to help sponsor label Oct 11, 2023
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (8a335bd) 46.23% compared to head (e2fdfd5) 44.44%.
Report is 181 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3713      +/-   ##
==========================================
- Coverage   46.23%   44.44%   -1.80%     
==========================================
  Files          78       80       +2     
  Lines        1276     1332      +56     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      587      +39     
- Partials      138      153      +15     
Files Coverage Δ
platform/app/src/routes/WorkList/filtersMeta.js 0.00% <ø> (ø)
platform/core/src/utils/addAccessors.js 9.09% <ø> (ø)
platform/core/src/utils/downloadCSVReport.js 0.00% <ø> (ø)
platform/core/src/utils/formatDate.js 0.00% <ø> (ø)
platform/core/src/utils/index.js 100.00% <ø> (ø)
...form/core/src/utils/isDisplaySetReconstructable.js 5.00% <ø> (+0.18%) ⬆️
...ils/metadataProvider/getPixelSpacingInformation.js 0.00% <ø> (ø)
platform/core/src/log.js 14.28% <0.00%> (-85.72%) ⬇️
...services/DicomMetadataStore/createStudyMetadata.js 0.00% <0.00%> (ø)
...ervices/DicomMetadataStore/createSeriesMetadata.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7c950...e2fdfd5. Read the comment docs.

@sedghi
Copy link
Member

sedghi commented Nov 9, 2023

can you please add before and after screenshots?

@sedghi
Copy link
Member

sedghi commented Dec 13, 2023

@igoroctaviano and @rodrigobasilio2022, please complete the pull request (PR) description and add relevant testing data, screenshots, etc.

@igoroctaviano
Copy link
Contributor

@igoroctaviano and @rodrigobasilio2022, please complete the pull request (PR) description and add relevant testing data, screenshots, etc.

I'm working on another PR related to SCOORD3D, I'll keep this PR as WIP for now.

@igoroctaviano igoroctaviano changed the title feat(SR): Add the ability to filter SRs based on selected displaySet WIP feat(SR): Add the ability to filter SRs based on selected displaySet Dec 13, 2023
@igoroctaviano
Copy link
Contributor

@rodrigobasilio2022 this PR was part of which issue?

@rodrigobasilio2022
Copy link
Collaborator Author

Probably this will be superseed depending on how the SCOORD3D will be defined. So probably leave it as it or close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IDC:priority Items that the Imaging Data Commons wants to help sponsor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants