-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP feat(SR): Add the ability to filter SRs based on selected displaySet #3713
WIP feat(SR): Add the ability to filter SRs based on selected displaySet #3713
Conversation
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev canceled.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3713 +/- ##
==========================================
- Coverage 46.23% 44.44% -1.80%
==========================================
Files 78 80 +2
Lines 1276 1332 +56
Branches 312 327 +15
==========================================
+ Hits 590 592 +2
- Misses 548 587 +39
- Partials 138 153 +15
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
can you please add before and after screenshots? |
@igoroctaviano and @rodrigobasilio2022, please complete the pull request (PR) description and add relevant testing data, screenshots, etc. |
I'm working on another PR related to SCOORD3D, I'll keep this PR as WIP for now. |
@rodrigobasilio2022 this PR was part of which issue? |
Probably this will be superseed depending on how the SCOORD3D will be defined. So probably leave it as it or close it |
Context
When an study has many SRs, some users prefer that only the SRs of the currently selected displyaSet are shown. This PR adds the ability to filter SRs based on active viewport display set
Changes & Results
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment