Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset orthanc reverse proxy to test unaccessible series - DO NOT MERGE #3734

Closed
wants to merge 1 commit into from

Conversation

salimkanoun
Copy link
Contributor

This PR is for reproducing the issue raised in #3674
And also to get back the docker container to work with Orthanc (was in previous commit, usefull in many case)

In the ngnix reverse proxy i add a specific location to forbide the access of one series, of course the StudyInstanceUID and SeriesInstanceUID should match the ressource you have.

So to reproduce :
Start the docker compose
Send a dicom study to orthanc with at least 2 series (localhost:8042 and go to import page, drag and drop file)
Update the nginx reverse proxy to one existing StudyInstanceUID and SeriesInstanceUID
Restart the docker compose to update the modified ngnix config
Open OHIF to this dicom web server, the HP should not start because one of the series is forbidden by the backend, it would be better if OHIF could consider the series as non available (missing) and continue tu run on whatever is accessible

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit ec47a05
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/653002b92329bb0008d4eae7
😎 Deploy Preview https://deploy-preview-3734--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit ec47a05
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/653002b935aca4000838f871
😎 Deploy Preview https://deploy-preview-3734--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #3734 (ec47a05) into master (8a335bd) will decrease coverage by 0.15%.
Report is 69 commits behind head on master.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3734      +/-   ##
==========================================
- Coverage   46.23%   46.09%   -0.15%     
==========================================
  Files          78       78              
  Lines        1276     1280       +4     
  Branches      312      312              
==========================================
  Hits          590      590              
- Misses        548      552       +4     
  Partials      138      138              
Files Coverage Δ
platform/core/src/utils/downloadCSVReport.js 0.00% <ø> (ø)
...ils/metadataProvider/getPixelSpacingInformation.js 0.00% <0.00%> (ø)
platform/core/src/log.js 14.28% <0.00%> (-85.72%) ⬇️
...services/DicomMetadataStore/createStudyMetadata.js 0.00% <0.00%> (ø)
...ervices/DicomMetadataStore/createSeriesMetadata.js 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33f1259...ec47a05. Read the comment docs.

@sedghi sedghi changed the title Reset orthanc reverse proxy to test unaccessible series Reset orthanc reverse proxy to test unaccessible series - DO NOT MERGE Oct 18, 2023
@sedghi
Copy link
Member

sedghi commented Oct 18, 2023

Thanks a lot !

@sedghi sedghi closed this Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants