Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tmtv-mode): Add Brush tools and move SUV peak calculation to web worker #4053

Merged
merged 28 commits into from
Apr 19, 2024
Merged

feat(tmtv-mode): Add Brush tools and move SUV peak calculation to web worker #4053

merged 28 commits into from
Apr 19, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Apr 19, 2024 •
edited
Loading

Move SUV peak calculation to web worker

Add Brush tools to tmtv mode

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

sedghi added 26 commits April 16, 2024 14:38
@sedghi
Fix styling issue in DynamicDataPanel and remove unused code in tmtv …
9db1f53 
…mode
@sedghi
Add support for displaySetFromUrl in defaultRouteInit.ts
cd26e15
@sedghi
Add support for dynamic threshold brush in segmentationButtons.ts
295db4f
@sedghi
Refactor measurement display string formatting in CircleROI, Rectangl…
ff02729 
…eROI, and EllipticalROI
@sedghi
Fix reuseDisplaySetUID logic in HangingProtocolService.ts
3e19edb
@sedghi
Add support for dynamic threshold brush shape in segmentationButtons.ts
fe30d13
@sedghi
Refactor measurement display string formatting in CircleROI, Rectangl…
eb6b1ee 
…eROI, EllipticalROI, and SplineROI
@sedghi
Merge branch 'master' of github.com:OHIF/Viewers into 3p8-rc1-again
928d946
@sedghi
Merge branch 'master' of github.com:OHIF/Viewers into 3p8-rc1-again
018bcd2
@sedghi
Refactor toolbar event registration in cornerstone extension
f089ed3
@sedghi
Merge branch 'master' of github.com:OHIF/Viewers into 3p8-rc1-again
fa72c6b
@sedghi
Add max3DTextureSize to appConfigState in App.tsx and pass appConfig …
05fe99e 
…to isDisplaySetReconstructable function in getDisplaySetInfo.js
@sedghi
Refactor toolbar event registration in cornerstone extension
7934571
@sedghi
Refactor Thumbnail component styles and remove unused margin style
3a62b67
@sedghi
Refactor Thumbnail and ThumbnailNoImage components to handle double t…
1558b72 
…ap events on touch devices
@sedghi
Update button labels and tooltips for zoom-in and magnify probe tools
c39c15c
@sedghi
Update migration guide for OHIF Viewer 3.8 release
63efeaf
@sedghi
Add AdvancedMagnifyTool to initCornerstoneTools.js
7695779
@sedghi
cs3d upgrade
7418128
@sedghi
Merge branch 'master' of github.com:OHIF/Viewers into 3p8-rc1-again
381794a
@sedghi
Fix hanging protocol toggle registration in init.ts
4542fd6
@sedghi
Merge branch 'master' of github.com:OHIF/Viewers into 3p8-rc1-again
161d6cd
@sedghi
Add new brush tools to ROIThresholdToolbox and handle ROI thresholdin…
6aac241 
…g in PanelROIThresholdSegmentation
@sedghi
Add new brush tools to ROIThresholdToolbox and update ROI thresholdin…
2595ed8 
…g in PanelROIThresholdSegmentation
@sedghi
Update brush tool names in various files
611f427
@sedghi
cs3d upgrade
f209f7a
@netlify Netlify
Copy link

netlify bot commented Apr 19, 2024 •
edited
Loading

✅ Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit c49d36a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6622c0b10aee4500083098a6
😎 Deploy Preview https://deploy-preview-4053--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 19, 2024 •
edited
Loading

✅ Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit c49d36a
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6622c0b19a01d60008585c87

@sedghi sedghi changed the title 3p8 rc1 again feat(tmtv-mode): Add Brush tools and move SUV peak calculation to web worker Apr 19, 2024
@sedghi sedghi merged commit 8192e34 into master Apr 19, 2024
6 of 7 checks passed
@cypress Cypress
Copy link

cypress bot commented Apr 19, 2024

1 failed test on run #3852 ↗︎

1 42 0 0 Flakiness 0

Details:

Refactor PanelService to use index as key in panelsData map
Project: Viewers Commit: c49d36ad61
Status: Failed Duration: 06:19 💡
Started: Apr 19, 2024 7:18 PM Ended: Apr 19, 2024 7:24 PM
Failed  cypress/integration/study-list/OHIFStudyList.spec.js • 1 failed test

View Output Video

Test Artifacts
OHIF Study List > Desktop resolution > maintains MRN filter upon return from viewer Test Replay Screenshots Video

Review all test suite changes for PR #4053 ↗︎

WillianVarela pushed a commit to cfaz-net/dicomviewer that referenced this pull request Apr 19, 2024
@sedghi @WillianVarela
feat(tmtv-mode): Add Brush tools and move SUV peak calculation to web…
0012160 
… worker (OHIF#4053)
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
@sedghi @thanh-nguyen-dang
feat(tmtv-mode): Add Brush tools and move SUV peak calculation to web…
c5549e7 
… worker (OHIF#4053)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sedghi