Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(viewport-webworker-segmentation): Resolve issues with viewport detection, webworker termination, and segmentation panel layout change #4059

Merged
merged 35 commits into from
Apr 22, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Apr 22, 2024

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

sedghi added 30 commits April 16, 2024 14:38
…to isDisplaySetReconstructable function in getDisplaySetInfo.js
Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 0f2954e
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/6626ad5523d0f400084fa397
😎 Deploy Preview https://deploy-preview-4059--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 0f2954e
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/6626ad5541154700087236dd

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.41%. Comparing base (8a335bd) to head (767f944).
Report is 339 commits behind head on master.

❗ Current head 767f944 differs from pull request most recent head 0f2954e. Consider uploading reports for the commit 0f2954e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4059      +/-   ##
==========================================
- Coverage   46.23%   44.41%   -1.83%     
==========================================
  Files          78       80       +2     
  Lines        1276     1333      +57     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      588      +40     
- Partials      138      153      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Apr 22, 2024

Passing run #3857 ↗︎

0 43 0 0 Flakiness 0

Details:

Fix UI notification service import in OHIFCornerstoneSEGViewport.tsx
Project: Viewers Commit: 0f2954eec7
Status: Passed Duration: 06:26 💡
Started: Apr 22, 2024 6:46 PM Ended: Apr 22, 2024 6:53 PM

Review all test suite changes for PR #4059 ↗︎

@sedghi sedghi changed the title 3p8 rc1 again fix(viewport-webworker-segmentation): Resolve issues with viewport detection, webworker termination, and segmentation panel layout change Apr 22, 2024
@sedghi sedghi merged commit 52a0c59 into master Apr 22, 2024
7 checks passed
WillianVarela pushed a commit to cfaz-net/dicomviewer that referenced this pull request Apr 30, 2024
…tection, webworker termination, and segmentation panel layout change (OHIF#4059)
thanh-nguyen-dang pushed a commit to uc-cdis/Viewers that referenced this pull request May 1, 2024
…tection, webworker termination, and segmentation panel layout change (OHIF#4059)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant