[OHI-1357] feat(static-wado): add support for case-insensitive searching #4603
+46
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
reviewed
Dec 13, 2024
sedghi
reviewed
Dec 13, 2024
Viewers
|
||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
feat/case-insensitive-searching-for-static-wado
|
| Run status |
|
| Run duration | 02m 05s |
| Commit |
|
| Committer | Ibrahim |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
44
|
| View all changes introduced in this branch ↗︎ | |
|
Can you try it in Orthanc too please? |
I did, it works fine |
sedghi
approved these changes
Dec 20, 2024
|
@wayfarer3130 can you take a look at this please |
extensions/default/src/DicomWebDataSource/utils/StaticWadoClient.ts
Outdated
Show resolved
Hide resolved
extensions/default/src/DicomWebDataSource/utils/StaticWadoClient.ts
Outdated
Show resolved
Hide resolved
wayfarer3130
requested changes
Dec 20, 2024
|
Also, please change the default.js and e2e.js configurations to set this on by default - you may need to modify an integration test to support that. |
thanks Bill, I'll do them as soon as I can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This adds the option to filter static-wado results without being case-sensitive. You need to set the
caseSensitiveproperty on your static wadodataSourcetofalse, the default istrue.Orthanc and other sources support case insensitive searching already.
Fixes OHI-1357
Close #4522