fix: Documentation and default enabled for bulkdata load #4607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ohif-platform-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sedghi
approved these changes
Dec 17, 2024
Viewers
|
||||||||||||||||||||||||||||||||||
| Project |
Viewers
|
| Branch Review |
fix/bulkdata-default-true
|
| Run status |
|
| Run duration | 02m 22s |
| Commit |
|
| Committer | Alireza |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
43
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/integration/measurement-tracking/OHIFDownloadSnapshotFile.spec.js • 1 failed test
| Test | Artifacts | |
|---|---|---|
| OHIF Download Snapshot File > checks displayed information for Desktop experience |
Test Replay
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Since bulkdata URI's are part of the base standard, they should be enabled by default in dicomweb datasources. As well, the documentation on configuring bulkdata was incorrect.
Changes & Results
Enable bulkdata uri resolution by default, with relative resolution series.
Added documentation.
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment