Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): Add Clipboard icon and update MetadataProvider for null checks #4615

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

sedghi
Copy link
Member

@sedghi sedghi commented Dec 18, 2024

fixes #4343

…checks

- Introduced a new Clipboard icon component in the Icons directory.
- Updated the Icons export to include the new Clipboard icon.
- Modified the MetadataProvider to use null checks instead of undefined checks for WindowCenter and WindowWidth.

This enhances the icon set and improves the robustness of the MetadataProvider class.
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 5533bd6
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/67630d9f0e32ee0008f68f62
😎 Deploy Preview https://deploy-preview-4615--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 5533bd6
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/67630d9f387adc000836bf45
😎 Deploy Preview https://deploy-preview-4615--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

cypress bot commented Dec 18, 2024

Viewers    Run #4576

Run Properties:  status check passed Passed #4576  •  git commit 5533bd620c: feat(icons): Add Clipboard icon and update MetadataProvider for null checks
Project Viewers
Branch Review fix/xa-stuff
Run status status check passed Passed #4576
Run duration 02m 04s
Commit git commit 5533bd620c: feat(icons): Add Clipboard icon and update MetadataProvider for null checks
Committer sedghi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 2
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 44
View all changes introduced in this branch ↗︎

@sedghi sedghi merged commit 93d7076 into master Dec 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] XA studies rendered with wrong BW balance
1 participant