Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SR): Bring back the onModeEnter for the cornerstone-dicom-sr extension that was accidentally removed by PR #4586 #4616

Conversation

jbocce
Copy link
Collaborator

@jbocce jbocce commented Dec 18, 2024

Context

The title says it all. See #4586.

Changes & Results

Testing

SRs should load.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows 11
  • Node version: 18.16.1
  • Browser: Chrome 131.0.6778.140

@jbocce jbocce requested a review from sedghi December 18, 2024 18:51
Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit e97e078
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/67631a4881aedc0008101e68
😎 Deploy Preview https://deploy-preview-4616--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 18, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit e97e078
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/67631a48d69f74000850d0c0
😎 Deploy Preview https://deploy-preview-4616--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi merged commit 2df8e1d into OHIF:master Dec 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants