Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolbars): Fix error when filtering out duplicate buttons for a button section. #4618

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jbocce
Copy link
Collaborator

@jbocce jbocce commented Dec 19, 2024

Context

There was an error introduced in PR #4586 in the ToolbarService.addButtonSection

Changes & Results

Fixed the error.

Testing

Attempt to add buttons to an existing button section. It should work.

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS:
  • Node version: 20.9.0
  • Browser: Chrome 131.0.6778.140

@jbocce jbocce requested a review from sedghi December 19, 2024 18:55
Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit 4cdf757
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/67646c041f084d00088cc239
😎 Deploy Preview https://deploy-preview-4618--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit 4cdf757
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/67646c04251560000869e3e5
😎 Deploy Preview https://deploy-preview-4618--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jbocce jbocce requested a review from wayfarer3130 December 21, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant