#170: upgrade Chart.js libraries #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the mustache template to the appropriate places in Controller code which populates pageNodeScripts, for #170
… the mustache template to the appropriate places in Controller code which populates pageNodeScripts. also added chart.js references to pageNodeScripts, moved here from the weird recursive loadScripts() logic in home.mustache, only configured that way to support IE, which we're not doing anymore. for #170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upgraded chart.js libraries to the latest to resolve an identified vulnerability. plus some additional cleanup in how those libraries get loaded, removing the weird recursive calls to loadScript() and consolidating the load of node scripts into pageNodeScripts where the rest of the Node-based modules are referenced. tested, no errors, everything appears to look just as it should. tooltip display is a little different, and the angle at which timestamps along the X axis are at a shallower angle, but those are trivial differences, if this vulnerability gets resolved.
also removed IE-specific stuff since we're not supporting it as as byproduct of cleaning up this part of the code, referencing a very old backlogged issue.