#171: improve documentation in properties files #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oal.custom-codings to service-request-order.bp-goal.codings (removed "custom-"), because the "custom-" part is a convention that indicates that there is a hard-coded coding that will always be used, and these "custom" codings are supplemental. that is not the case here.
…st-order.bp-goal.codings (removed "custom-"), because the "custom-" part is a convention that indicates that there is a hard-coded coding that will always be used, and these "custom" codings are supplemental. that is not the case here.
…of preparing documentation in properties files. I don't want unused properties to exist and to say something like "oh this property exists but we don't use it please ignore" when we can just remove it. it's totally safe. for #171
… and functions as a part of preparing documentation in properties files. I don't want unused properties to exist and to say something like "oh this property exists but we don't use it please ignore" when we can just remove it. it's totally safe. for #171
…vation.Query and Observation.Strategy, as there is now only one version of the query used to get Observations (specifying Code is superfluous and unnecessary, and out of convention from how the rest of the properties are specified). for #171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added all sorts of documentation to properties files.
changes include:
Observation.Category.QueryandObservation.Category.Strategyfrom fhirqueries.propertiesObservation.Code.QuerytoObservation.Query, and renamedObservation.Code.StrategytoObservation.Strategyin fhirqueries.properties, as there is now only one version of the Observation query that exists (the other Category form was literally never used, so I removed it as a part of this documentation task, I want to make sure that we're not documenting things that are never used anywhere ever)service-request-order.bp-goal.custom-codingstoservice-request-order.bp-goal.codingsin fhirconfig.properties