Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http1 removetx 5921 v10 #417

Closed
wants to merge 5 commits into from
Closed

Http1 removetx 5921 v10 #417

wants to merge 5 commits into from

Conversation

catenacyber
Copy link
Contributor

#416 with dummy debug commit

@catenacyber catenacyber mentioned this pull request Mar 11, 2024
Closed
@victorjulien
Copy link
Member

Is the failing test above already enough proof?

@catenacyber
Copy link
Contributor Author

Is the failing test above already enough proof?

Not yet, pushed another version passing tests

@victorjulien
Copy link
Member

It aborts, but again only in the unix socket test.

@catenacyber
Copy link
Contributor Author

Do you know which one of the 2 aborts ?

@catenacyber
Copy link
Contributor Author

Does the unix socket test free transactions differently ?

Anyways, I think we should not get this optimization soon...

@victorjulien
Copy link
Member

Does the unix socket test free transactions differently ?

It shouldn't matter.

Anyways, I think we should not get this optimization soon...

Agree. I will see if I can reproduce it manually after the releases next week.

@catenacyber
Copy link
Contributor Author

Does the unix socket test free transactions differently ?

It shouldn't matter.

Sure, just trying to understand the issue, to reproduce and fix it.
It seems to happen because transaction are not freed in order...

@catenacyber
Copy link
Contributor Author

Replaced by #418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@catenacyber @victorjulien