use cookie to ensure write to a valid rule dir #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inashivb
commented
Mar 24, 2022
| if os.path.exists(directory): | ||
| if not os.path.exists(cookie_path) and os.listdir(directory): | ||
| logger.error("{} -- doesn't look like a suricata-update rule directory".format(directory)) | ||
| sys.exit(1) |
There was a problem hiding this comment.
@jasonish do you think this is as per your expectations?
Questions:
- How do we ensure that this does not break the current setups? Because we don't have a cookie already in the rule dir.
- Is checking for dir good enough for determining "first run"?
- Should the cookie be in say
<prefix>/suricataor<prefix>/suricata/rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to redmine ticket: https://redmine.openinfosecfoundation.org/issues/2691
Previous PR: #157
Changes since v1:
Entirely revamped. Used cookie approach suggested by Jason on Redmine
Known TODOs: