Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch: handle bare file urls not ending in .rules #340

Closed
wants to merge 2 commits into from

Conversation

jasonish
Copy link
Member

If a URL is a bare file, and does not end in .rules, Suricata-Update will ignore it. Such URLs might look like:

  • https:///1011

Tested with https://codemonkey.net/tmp/1011

Ticket: https://redmine.openinfosecfoundation.org/issues/3664

If a URL is a bare file, and does not end in .rules, Suricata-Update
will ignore it.  Such URLs might look like:

- https://<misp>/1011

Ticket: #3664
@jasonish jasonish requested a review from inashivb February 29, 2024 15:45
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well. LGTM 🚀

@jasonish
Copy link
Member Author

jasonish commented Mar 5, 2024

Merged.

@jasonish jasonish closed this Mar 5, 2024
@jasonish jasonish deleted the bare-rule-files/v1 branch March 19, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants