fix: properly handle directories for local files #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading local files and rule files are nested in a folder, the
current behavior prepends the base path and not the nested path which
results in a file not found error. This change updates this to use the
`dirpath` parameter from `os.walk` so that it is handled correctly.
Given a structure of
/tmp/rules/
├── file1.rules
└── nested
└── file2.rules
Today it would try to load this as the following
* /tmp/rules/file1.rules
* /tmp/rules/file2.rules
With the fix this would be
* /tmp/rules/file1.rules
* /tmp/rules/nested/file2.rules
Signed-off-by: Ben Magistro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading local files and rule files are nested in a folder, the current behavior prepends the base path and not the nested path which results in a file not found error. This change updates this to use the
dirpathparameter fromos.walkso that it is handled correctly.Given a structure of
Today it would try to load this as the following
With the fix this would be
https://redmine.openinfosecfoundation.org/issues/7370