Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Associate named user by email #3

Open
wants to merge 2 commits into
base: subscription-lists
Choose a base branch
from

Conversation

jo-wojtowicz
Copy link

We were recommended by the Airship support to change the way we associate email channels with named user IDs. This operation is not currently supported by the Airship's Ruby Library, so we decided to add it to our fork.

Connects to the issue: https://github.com/OLIOEX/community-team/issues/1188

https://docs.airship.com/api/ua/index.html#operation-api-named_users-associate-post

@lloydwatkin
Copy link
Member

This should be contributed to Airship :)

@lloydwatkin
Copy link
Member

You are missing documentation updates here 👍

@jo-wojtowicz
Copy link
Author

jo-wojtowicz commented Jun 28, 2022

@lloydwatkin regarding contributing to Airship, there is this: urbanairship#132 PR containing current changes - would that be sufficient? :)

Regarding your comment:

You are missing documentation updates here 👍

I am not sure if I understand correctly, do you mean we should add some documentation for these changes? Or that there were some documentation changes for the Airship library that we have not taken into account while implementing our changes?

Thank you very much for your help :)

@lloydwatkin
Copy link
Member

@majhogee take a look in the docs directory. You'll need to add documentation for this change

@lloydwatkin
Copy link
Member

@lloydwatkin regarding contributing to Airship, there is this: urbanairship#132 PR containing current changes - would that be sufficient? :)

Yes but please remove internal references to our repositories ASAP

@jo-wojtowicz
Copy link
Author

Thank you @lloydwatkin, I've removed the reference to our repo, I will chat with @eviepolds about updating the docs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants