chore: use react-router new routing approach RouterProvider

[mariojsnunes]

PR Checklist

• - Commit messages are descriptive, it will be used in our Release Notes

PR Type

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Developer experience (improves developer workflows for contributing to the project)

Description

https://github.com/remix-run/remix/blob/bbead33bf530be030d16a1466b52cd99d077382a/decisions/0005-remixing-react-router.md#react-router-api-surface
Use the newer and recommended routing approach to make it easier to migrate to Remix later.

[mariojsnunes]

I'll wait for someone else to take a look. And also test on the preview website.

[github-actions]

Visit the preview URL for this PR (updated for commit a387fd8):

https://onearmy-next--pr3761-chore-react-router-e-hkf1dsp1.web.app

_{(expires Sun, 11 Aug 2024 14:27:45 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59}

[benfurber]

Could deffo refactor the routing setup but not the focus of this PR. Will do a quick manual check on the preview build too.

[cypress]

Passing run #6011 ↗︎

0

71

1

0

0

Details:

fix: confirmation modal and tests
Project: onearmy-community-platform	Commit: a387fd898e
Status: Passed	Duration: 04:13 💡
Started: Jul 12, 2024 10:37 AM	Ended: Jul 12, 2024 10:41 AM

Review all test suite changes for PR #3761 ↗︎

[benfurber]

A basic click through confirmed all routes working as before.

[mariojsnunes]

Found that after this change, confirmation on leaving the page no longer works.
Added a fix that also improves the confirmation to use our modal instead of the browser default one. (easier to test too)

Besides that, found a few more instances where forms were being submitted by clicking other buttons, which were breaking some tests. (because the default type of buttons is submit, not button)

[mariojsnunes]

found more issues when saving forms

[mariojsnunes]

Note the change on UnsavedChangesDialog. The behaviour no longer relies on uploadComplete state. There were tricky rendering issues that caused that observable to not update on this component context.
Now it relies only on the dirty and submitSuccess variables.
For submitSuccess to work as intended, had to add await to the onSubmit calls.

[benfurber]

Awesome, this looks like really good work @mariojsnunes.

[onearmy-bot]

🎉 This PR is included in version 1.199.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀