verticalList || ImageGallery buttons issue #4099 solved #4105
Conversation
|
@sanwalsulehri the pipeline is failing due to code not formatted. you should be able to fix that by running 
|
|
ok nw i am done this |
|
hey @mariojsnunes thanks for guide and now see man |
onearmy-community-platform
|
||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/4105
|
| Run status |
|
| Run duration | 05m 28s |
| Commit |
|
| Committer | sanwalsulehri |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
79
|
| View all changes introduced in this branch ↗︎ | |
| } | ||
|
|
||
| /* Set red background for PhotoSwipe navigation buttons */ | ||
| .pswp__button--arrow--prev { |
There was a problem hiding this comment.
are all these !important necessary?
There was a problem hiding this comment.
the styling not applied that's why man everything checked no failure you see
There was a problem hiding this comment.
@mariojsnunes everything passed mean checked now no failure that's a good news
There was a problem hiding this comment.
@mariojsnunes i think now this issue are solved so plz merge and closed this issue😃🎉
There was a problem hiding this comment.
any help you want in code or remove anything or solve any issue feel free to tell me i will solved this @mariojsnunes
|
why not you merged this code guys @mariojsnunes plz tell me if you wnat any change in code or somewhere i do but merged this code plz |
@sanwalsulehri please be patient, we are not working on this fulltime, it could even take a few days. I'd like for @benfurber to review this as well. |
|
ok thanks @mariojsnunes and sorry for this also😃😃 |
|
Hey @sanwalsulehri, thanks for your first contribution! I think I'm looking for a different approach to this ticket. The issue asks for a new component, for us that means in the component library probably called something like Make sense? |
|
Also, it would be super helpful if you could add screenshots of the change to the PR description. :) |
|
Ok i will try but not for now tomoroow i wil do this easily bcz i am on an function |
|
Awesome, thanks @sanwalsulehri |
|
Hi @benfurber i try through sx={{}} but its not working you get the layout the !important are not harmfull for your code and this is a little css code that are absolutely not harmfull for your code so don't worry and plz merged bcz the sx={{}} are not working🙌 |
|
@sanwalsulehri If you start by editing this props, you'll work it out: |
|
@benfurber you see here the sx styles not working |
|
@benfurber that's why i am using css you use a little bit css in your project so their is no changes created if we ad 5 more lines of css!!!!! |
|
@benfurber brother i think css is good for this if you have anyother idea plz tell me i will try the idea also |
|
@sanwalsulehri If you were editing the sx props from this code block, I'm not suprised this doesn't show a change as that's a different component. |
|
ok i got it can you tell me in which component these arrows are if you know plz tell me bcz its too much helpfull for me @benfurber |
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Describe the new behaviour
If useful, provide screenshot or capture to highlight main changes
Does this PR introduce a DB Schema Change or Migration?
Git Issues
Closes #4099
What happens next?
Thanks for the contribution! We try to make sure all PRs are reviewed ahead of our monthly maintainers call (first Monday of the month)
If the PR is working as intended it'll be merged and included in the next platform release, if not changes will be requested and re-reviewed once updated.
If you need more immediate feedback you can try reaching out on Discord in the Community Platform
developmentchannel.