Skip to content

Commit

Permalink
Fix service account key deprecation (#24)
Browse files Browse the repository at this point in the history
* Fix service account key deprecation

* auto patch increment

* Update comment to use actions/checkout@v3 and remove speech marks

Co-authored-by: ras-rm-pr-bot <[email protected]>
  • Loading branch information
LJBabbage and ras-rm-pr-bot authored Jul 6, 2022
1 parent 58df359 commit 058f7de
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 12 deletions.
12 changes: 8 additions & 4 deletions .github/workflows/comment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,16 @@ jobs:
runs-on: ubuntu-latest
if: contains(github.event.comment.body, '/deploy')
steps:
- uses: google-github-actions/setup-gcloud@v0
- uses: actions/checkout@v3
- name: Authenticate with Google Cloud
id: auth
uses: google-github-actions/auth@v0
with:
credentials_json: ${{ secrets.GCR_KEY }}
- name: Setup Google Cloud SDK
uses: google-github-actions/setup-gcloud@v0
with:
project_id: ${{ secrets.GOOGLE_PROJECT_ID }}
service_account_key: ${{ secrets.GCR_KEY }}
export_default_credentials: true

- uses: onsdigital/ras-rm-spinnaker-action@main
with:
comment-body: ${{ github.event.comment.body }}
Expand Down
13 changes: 7 additions & 6 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,16 @@ jobs:
restore-keys: |
${{ runner.os }}-maven-
- uses: google-github-actions/setup-gcloud@v0
- name: Authenticate with Google Cloud
id: auth
uses: google-github-actions/auth@v0
with:
version: '270.0.0'
service_account_key: ${{ secrets.GCR_KEY }}
export_default_credentials: true
# Configure docker to use the gcloud command-line tool as a credential helper
credentials_json: ${{ secrets.GCR_KEY }}
- name: Setup Google Cloud SDK
uses: google-github-actions/setup-gcloud@v0
- run: |
gcloud auth configure-docker
- name: Test
run: make test

Expand Down
4 changes: 2 additions & 2 deletions _infra/helm/banner-api/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ description: A Helm chart for Kubernetes

type: application

version: 2.0.0
version: 2.0.1

appVersion: 2.0.0
appVersion: 2.0.1

0 comments on commit 058f7de

Please sign in to comment.