Fix booleans not being casted properly

OP-Engineering · Sep 19, 2024 · 19691a1 · 19691a1
1 parent e175660
commit 19691a1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/cpp/bridge.cpp b/cpp/bridge.cpp
@@ -204,8 +204,10 @@ inline void opsqlite_bind_statement(sqlite3_stmt *statement,
     int sqIndex = ii + 1;
     JSVariant value = values->at(ii);
 
-    if (std::holds_alternative<bool>(value) ||
-        std::holds_alternative<int>(value)) {
+    if (std::holds_alternative<bool>(value)) {
+      sqlite3_bind_int(statement, sqIndex,
+                       static_cast<int>(std::get<bool>(value)));
+    } else if (std::holds_alternative<int>(value)) {
       sqlite3_bind_int(statement, sqIndex, std::get<int>(value));
     } else if (std::holds_alternative<long long>(value)) {
       sqlite3_bind_double(statement, sqIndex,

diff --git a/example/src/tests/queries.spec.ts b/example/src/tests/queries.spec.ts
@@ -29,7 +29,7 @@ export function queriesTests() {
       await db.execute('DROP TABLE IF EXISTS T1;');
       await db.execute('DROP TABLE IF EXISTS T2;');
       await db.execute(
-        'CREATE TABLE User ( id INT PRIMARY KEY, name TEXT NOT NULL, age INT, networth REAL, nickname TEXT) STRICT;',
+        'CREATE TABLE User (id INT PRIMARY KEY, name TEXT NOT NULL, age INT, networth REAL, nickname TEXT) STRICT;',
       );
     } catch (e) {
       console.error('error on before each', e);
@@ -85,6 +85,11 @@ export function queriesTests() {
       expect(res.rows?.item).to.be.a('function');
     });
 
+    it('Casts booleans to ints correctly', async () => {
+      await db.execute(`SELECT ?`, [1]);
+      await db.execute(`SELECT ?`, [true]);
+    });
+
     it('Insert and query with host objects', async () => {
       const id = chance.integer();
       const name = chance.name();