Merge pull request #195 from OP-Engineering/oscar/dedupe-to-variant-f…

…unction De-dupe to variant function and correctly throw when object is passed
OP-Engineering · Dec 1, 2024 · 28f9c41 · 28f9c41
2 parents 00489fe + d204539
commit 28f9c41
Show file tree

Hide file tree

Showing 8 changed files with 259 additions and 296 deletions.
diff --git a/cpp/DBHostObject.cpp b/cpp/DBHostObject.cpp
@@ -48,7 +48,7 @@ void DBHostObject::flush_pending_reactive_queries(
           [this,
            results = std::make_shared<std::vector<DumbHostObject>>(results),
            callback = query->callback, metadata, status = std::move(status)] {
-            auto jsiResult = createResult(rt, status, results.get(), metadata);
+            auto jsiResult = create_result(rt, status, results.get(), metadata);
             callback->asObject(rt).asFunction(rt).call(rt, jsiResult);
           });
     }
@@ -486,7 +486,7 @@ void DBHostObject::create_jsi_functions() {
                metadata, status = std::move(status), resolve, reject] {
                 if (status.type == SQLiteOk) {
                   auto jsiResult =
-                      createResult(rt, status, results.get(), metadata);
+                      create_result(rt, status, results.get(), metadata);
                   resolve->asObject(rt).asFunction(rt).call(
                       rt, std::move(jsiResult));
                 } else {

diff --git a/cpp/PreparedStatementHostObject.cpp b/cpp/PreparedStatementHostObject.cpp
@@ -69,7 +69,7 @@ jsi::Value PreparedStatementHostObject::get(jsi::Runtime &rt,
                metadata, resolve, reject] {
                 if (status.type == SQLiteOk) {
                   auto jsiResult =
-                      createResult(rt, status, results.get(), metadata);
+                      create_result(rt, status, results.get(), metadata);
                   resolve->asObject(rt).asFunction(rt).call(
                       rt, std::move(jsiResult));
                 } else {