Minor fixes

OP-Engineering · Mar 12, 2024 · 4215e6a · 4215e6a
1 parent c7c567c
commit 4215e6a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/cpp/bindings.cpp b/cpp/bindings.cpp
@@ -75,11 +75,14 @@ void install(jsi::Runtime &rt,
       throw std::runtime_error(
           "[OP SQLite] using SQLCipher encryption key is required");
     }
-#else
-    if (!encryptionKey.empty()) {
-      throw std::runtime_error("[OP SQLite] SQLCipher is not enabled, "
-                               "encryption key is not allowed");
-    }
+//      TODO(osp) find a way to display the yellow box from c++
+// #else
+//    if (!encryptionKey.empty()) {
+
+//        RCTLogWarn(@"Your message")
+//      throw std::runtime_error("[OP SQLite] SQLCipher is not enabled, "
+//                               "encryption key is not allowed");
+//    }
 #endif
 
     if (!location.empty()) {

diff --git a/cpp/bridge.cpp b/cpp/bridge.cpp
@@ -47,7 +47,7 @@ BridgeResult opsqlite_open(std::string const &dbName,
                            std::string const &encryptionKey) {
 #else
 BridgeResult opsqlite_open(std::string const &dbName,
-                           std::string const &lastPath) {
+                           std::string const &last_path) {
 #endif
   std::string dbPath = get_db_path(dbName, last_path);
 

diff --git a/example/ios/Podfile.lock b/example/ios/Podfile.lock
@@ -1240,7 +1240,7 @@ SPEC CHECKSUMS:
   glog: c5d68082e772fa1c511173d6b30a9de2c05a69a2
   hermes-engine: 34df9d5034e90bd9bf1505e1ca198760373935af
   libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
-  op-sqlite: 3f250045135ecb889ea09bb5a4d43e997eb94a58
+  op-sqlite: 6e2f955abb2f307107edfb2f128c99089b03ef8d
   RCT-Folly: 7169b2b1c44399c76a47b5deaaba715eeeb476c0
   RCTRequired: 6dda55e483f75d2b43781d8ad5bd7df276a50981
   RCTTypeSafety: df0f2632f4e89938b9b9f6152b5e6c66fc6e969e