More optimizations

OP-Engineering · Oct 3, 2024 · 60ac1b8 · 60ac1b8
1 parent c10764c
commit 60ac1b8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/cpp/DBHostObject.cpp b/cpp/DBHostObject.cpp
@@ -379,7 +379,7 @@ void DBHostObject::create_jsi_functions() {
       auto resolve = std::make_shared<jsi::Value>(rt, args[0]);
       auto reject = std::make_shared<jsi::Value>(rt, args[1]);
 
-      auto task = [&rt, this, query, params = std::move(params), resolve,
+      auto task = [&rt, this, query = std::move(query), params = std::move(params), resolve,
                    reject, invoker = this->jsCallInvoker]() {
         try {
 

diff --git a/cpp/bridge.cpp b/cpp/bridge.cpp
@@ -315,7 +315,7 @@ BridgeResult opsqlite_execute_prepared_statement(
       }
 
       if (results != nullptr) {
-        results->push_back(row);
+        results->emplace_back(row);
       }
 
       break;
@@ -335,7 +335,7 @@ BridgeResult opsqlite_execute_prepared_statement(
           metadata.fields.emplace_back("type",
                                        type == nullptr ? "UNKNOWN" : type);
 
-          metadatas->push_back(metadata);
+          metadatas->emplace_back(metadata);
           i++;
         }
       }
@@ -400,11 +400,9 @@ BridgeResult opsqlite_execute(std::string const &name, std::string const &query,
   int status, current_column, column_count, column_type;
   std::string column_name, column_declared_type;
   std::vector<std::string> column_names;
-  column_names.reserve(20);
   std::vector<std::vector<JSVariant>> rows;
   rows.reserve(20);
   std::vector<JSVariant> row;
-  row.reserve(10);
 
   do {
     const char *query_str =
@@ -432,6 +430,7 @@ BridgeResult opsqlite_execute(std::string const &name, std::string const &query,
     }
 
     column_count = sqlite3_column_count(statement);
+    column_names.reserve(column_count);
     bool is_consuming_rows = true;
     double double_value;
     const char *string_value;
@@ -449,7 +448,7 @@ BridgeResult opsqlite_execute(std::string const &name, std::string const &query,
       case SQLITE_ROW:
         current_column = 0;
         row = std::vector<JSVariant>();
-        column_count = sqlite3_column_count(statement);
+        row.reserve(column_count);
 
         while (current_column < column_count) {
           column_type = sqlite3_column_type(statement, current_column);
@@ -494,7 +493,7 @@ BridgeResult opsqlite_execute(std::string const &name, std::string const &query,
           current_column++;
         }
 
-        rows.push_back(row);
+        rows.emplace_back(std::move(row));
         break;
 
       case SQLITE_DONE: