Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pure async functions and bring back non-host-object API #142

Merged
merged 44 commits into from
Sep 18, 2024

Conversation

ospfranco
Copy link
Contributor

No description provided.

@rvibit
Copy link

rvibit commented Sep 9, 2024

@ospfranco so in new version we'll not have sync API, just like we have now?

@ospfranco
Copy link
Contributor Author

No, it's too much work to keep both in sync

@rvibit
Copy link

rvibit commented Sep 9, 2024

No, it's too much work to keep both in sync

Oh ok, i like sync api more but can't do anything now 😅

@ospfranco
Copy link
Contributor Author

sync API is in almost all cases the wrong API to use. It's easier to use but except for the most simplest of queries brings no other value than DX.

@rvibit
Copy link

rvibit commented Sep 9, 2024

sync API is in almost all cases the wrong API to use. It's easier to use but except for the most simplest of queries brings no other value than DX.

Ah ok got it

@omniphx
Copy link

omniphx commented Sep 9, 2024

@ospfranco will this change restore the use of the spread operator?

@ospfranco
Copy link
Contributor Author

Yes

@patlux
Copy link

patlux commented Sep 12, 2024

That's really sad...time to move to expo-sqlite for the sync api

# Conflicts:
#	example/ios/OPSQLiteExample.xcodeproj/xcshareddata/xcschemes/release.xcscheme
#	example/ios/Podfile.lock
#	package.json
@ospfranco ospfranco merged commit 582ef84 into main Sep 18, 2024
7 checks passed
@ospfranco ospfranco deleted the oscar/bring-back-non-host-object-api branch September 18, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants