Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libsql to 3d52c07f5d1df9caa56fb201fb3009924b26fd05 #188

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

haaawk
Copy link
Contributor

@haaawk haaawk commented Nov 26, 2024

It includes some fixes to vector search.

@haaawk
Copy link
Contributor Author

haaawk commented Nov 26, 2024

Android tests are passing:
image

@haaawk
Copy link
Contributor Author

haaawk commented Nov 26, 2024

I'm struggling a bit with getting IOS simulator to run @ospfranco

╰──> yarn ios
info Found Xcode workspace "OPSQLiteExample.xcworkspace"
info Launching iPhone 15 Pro (iOS 17.5)
info Building (using "xcodebuild -workspace OPSQLiteExample.xcworkspace -configuration Debug -scheme debug -destination id=E69CF751-2C6A-4B96-B9E6-162DD7B0A11D")

info 💡 Tip: Make sure that you have set up your development environment correctly, by running npx react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor 

node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

[UnhandledPromiseRejection: This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). The promise rejected with the reason "Error: Failed to build ios project. "xcodebuild" exited with error code '70'. To debug build logs further, consider building your app with Xcode.app, by opening 'OPSQLiteExample.xcworkspace'.".] {
  code: 'ERR_UNHANDLED_REJECTION'
}

Node.js v18.17.0

@ospfranco
Copy link
Contributor

ospfranco commented Nov 26, 2024

Just FYI the in-app tests are now baked into the Github actions tests, no need to posts screenshots. The error you posted is not pointing to the actual Xcode error, it's better if you build it from xcode and you check the native build logs there.

At least on this build logs, it seems the chosen emulator does not exist on CI:

https://github.com/OP-Engineering/op-sqlite/actions/runs/12031060231/job/33539770529?pr=188

I can see you didn't change anything though. Let me try a local build.

@ospfranco
Copy link
Contributor

It's compiling just fine for me. Maybe your environment changed since last time.

CleanShot 2024-11-26 at 14 20 48@2x

@haaawk
Copy link
Contributor Author

haaawk commented Nov 26, 2024

Updating simulator to IOS 18.1 helped:
image

@ospfranco
Copy link
Contributor

ospfranco commented Nov 26, 2024

Nice!

I fixed the CI command, you can merge main into your branch or rebase if you want, should fix the CI tests

@haaawk
Copy link
Contributor Author

haaawk commented Nov 26, 2024

It seems you didn't do a pod install? I'm getting changes on the Podfile.lock:

CleanShot 2024-11-26 at 14 23 53@2x

I did - just didn't commit Podfile.lock

@haaawk haaawk force-pushed the libsql_update_26_11_2024 branch from 33d1daf to 397b3eb Compare November 26, 2024 15:08
@haaawk
Copy link
Contributor Author

haaawk commented Nov 26, 2024

Rebased on main

@ospfranco ospfranco merged commit bf2f4e2 into OP-Engineering:main Nov 26, 2024
7 checks passed
@ospfranco
Copy link
Contributor

Thanks, release 11.0.1 is now building and will contain this bump.

@haaawk
Copy link
Contributor Author

haaawk commented Nov 26, 2024

Thanks, release 11.0.1 is now building and will contain this bump.

Thanks @ospfranco !!!

@simonwh
Copy link

simonwh commented Nov 27, 2024

Thanks guys! @ospfranco - can you push 11.0.1 to npm?

@ospfranco
Copy link
Contributor

@simonwh
Copy link

simonwh commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants