Add WTHPH+WBHPH keywords #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakim-hove
reviewed
Dec 1, 2017
opm/output/eclipse/Summary.cpp
Outdated
|
|
||
| double bhp_hist; | ||
| if ( sched_well->isProducer( timestep ) ) { | ||
| bhp_hist = sched_well->getProductionProperties( timestep ).BHPH; |
There was a problem hiding this comment.
Please don't add all these extra braces:
if (sched_well->isProducer( timestep ))
bhp_hist = sched_well->getProd ...
else
bhp_hist = ...
joakim-hove
reviewed
Dec 1, 2017
tests/summary_deck.DATA
Outdated
| W_1 SHUT ORAT 10.1 10 10.2 / | ||
| W_2 SHUT ORAT 20.1 20 20.2 / | ||
| W_1 SHUT ORAT 10.1 10 10.2 0 0 0.2 0.1 / | ||
| W_2 SHUT ORAT 20.1 20 20.2 0 0 1.2 1.1 / |
There was a problem hiding this comment.
Since I assume the two 0 values are not tested for in any way you can just do:
W_1 SHUT ORAT 10.1 10 10.2 2* 0.2 0.1 /
|
Except the brace disease this can be merged when the parser PR is merged. |
sveinung-r
force-pushed
the
Well_pri_3_keywords
branch
from
244f9e0 to
6698381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on pull request OPM/opm-parser#1162.