Parse new set of keywords #1010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMWSET should, similar to ALL, expand to a set of group property counting keywords.
FMWSET should, similar to ALL and GMWSET, expand to a set of field property counting keywords.
Adding the DEBUG keyword specification. Makes us no longer choke on it, but we're not using it for anything in partcular. The keyword name is DEBUG_ since DEBUG often is defined as a macro in C++ and the auto generation would then fail. We look up the name itself by using the deck_names field.
|
I think this should just be merged right away!? |
|
Happy to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely addressing #999
This PR does not add support for any new keywords¹ except that we no longer crash on the keywords reported as problematic in #999. The keywords aren't exposed via EclipseState nor will they affect flow's behaviour, but at least we won't crash and burn on them. This is roughly equivalent to using PARSE_RANDOM_KEYWORD option in a Deck that uses these keywords, but more robust as opm-parser now has a concept of their structure.
¹ We already support several of the keywords GMWSET and FMWSET expand to, and this subset is obviously supported.