Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed to TimeMap api - using std::time_t #1222

Merged
merged 1 commit into from
Jun 20, 2017
Merged

Changed to TimeMap api - using std::time_t #1222

merged 1 commit into from
Jun 20, 2017

Conversation

joakim-hove
Copy link
Member

Downstream of: OPM/opm-parser#1092

@joakim-hove joakim-hove mentioned this pull request Jun 19, 2017
Merged
@atgeirr
Copy link
Member

atgeirr commented Jun 19, 2017

Looks fine, feel free to merge when upstream is done and tests are green.

Just one tiny condition: make a sanity-test run of SPE1 or something to verify that printed dates remain the same.

@joakim-hove
Copy link
Member Author

jenkins build this opm-parser=1092 ewoms=198 please

@joakim-hove
Copy link
Member Author

Just one tiny condition: make a sanity-test run of SPE1 or something to verify that printed dates remain the same.

Of course I can do that - but seriously; we have tests for this?!

@atgeirr
Copy link
Member

atgeirr commented Jun 19, 2017

Of course I can do that - but seriously; we have tests for this?!

No, which is why I asked you to verify it...

@joakim-hove joakim-hove mentioned this pull request Jun 19, 2017
Open
@joakim-hove
Copy link
Member Author

course I can do that - but seriously; we have tests for this?!

No, which is why I asked you to verify it...

Hopefully we have soon: OPM/opm-output#195

@joakim-hove
Copy link
Member Author

joakim-hove commented Jun 19, 2017 •
edited
Loading

Hopefully we have soon: OPM/opm-output#195

Well - that was a slightly larger job than I thought: so although I still think we should have such a test I have done a manual sanity check of SPE1 now.

@atgeirr
Copy link
Member

atgeirr commented Jun 20, 2017

Well - that was a slightly larger job than I thought: so although I still think we should have such a test I have done a manual sanity check of SPE1 now.

I agree, and appreciate both the test and the interim manual check! I guess this should be merged, then?

@joakim-hove joakim-hove merged commit eafadaa into OPM:master Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joakim-hove @atgeirr