Compositional simulator expanded to three phases #5851
Conversation
svenn-t
force-pushed
the
dummy_water_compositional
branch
from
4a79ef0 to
4a0b8ab
Compare
svenn-t
force-pushed
the
dummy_water_compositional
branch
from
4a0b8ab to
253e5c2
Compare
svenn-t
force-pushed
the
dummy_water_compositional
branch
from
b6ea038 to
41b232d
Compare
|
Sorry for the delay. But I will review the PR now. Due to the change in master branch, there is some update needed in |
Note: compositional is now always three phase!
Choice of simulator is based on if WATER is present in RUNSPEC.
svenn-t
force-pushed
the
dummy_water_compositional
branch
from
41b232d to
20ca154
Compare
I've pushed a new update with changes in the mentioned file. |
opm/simulators/flow/FIPContainer.cpp
Outdated
| INSTANTIATE_COMP_TWOPHASE(4) | ||
| INSTANTIATE_COMP_TWOPHASE(5) | ||
| INSTANTIATE_COMP_TWOPHASE(6) | ||
| INSTANTIATE_COMP_TWOPHASE(7) |
There was a problem hiding this comment.
make a new macro
#define INSTANTIATE_COMP(NUM) \
INSTANTIATE_COMP_THREEPHASE(NUM) \
INSTANTIATE_COMP_TWOPHASE(NUM)
less duped lines, easier maintenance (you can still call the threephase one for 0).
| So /= sumS; | ||
| Sg /= sumS; | ||
| Sw /= sumS; |
There was a problem hiding this comment.
Just leaving some notes for later,
should we update the water saturation in the fluidState_ again here?
|
I is very well done job. I went through without noticing anything significant. We will wait to check against some reference output. It is possible there will be some minor comments here and there. I will invite @akva2 to have a look for the part that he is interested, since he has some quite some overview related FluidSystem. |
Added a "dummy"/immiscible water phase to the compositional simulator using the three-phase fluid system in OPM/opm-common#4410. An additional equation for the water phase has been added with water saturation as primary variable. Water phase properties are set using standard keywords as in black oil simulations.