Separate keyword validation for fully supported keywords #5866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins build this please |
|
jenkins build this please |
akva2
reviewed
Jan 14, 2025
| const PartiallySupportedKeywords<std::string>& string_items, | ||
| const PartiallySupportedKeywords<int>& int_items, | ||
| const PartiallySupportedKeywords<double>& double_items, | ||
| KeywordValidator(const UnsupportedKeywords& unsupported_keywords, |
There was a problem hiding this comment.
Imho this is getting out of hand. I'd introduce some struct, e.g.
struct Supported
{
SupportedKeywords<std::string>& string;
SupportedKeywords<int>& int;
SupportedKeywords<double>& double;
};and adjust constructor to
KeywordValidator(unsupported, partially_supported, fully_supported, special)and adjust getters accordingly.
|
jenkins build this please |
|
jenkins build this please |
akva2
approved these changes
Feb 6, 2025
|
It is approved and jenkins is green. Let us get it in now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid abusing 'PartiallySuppportedFlowKeywords' to for non-contextual verification of keywords that are actually fully supported.