Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass on current well state to (implicit) potential calculations #5929

Conversation

steink
Copy link
Contributor

@steink steink commented Jan 30, 2025

Implicit potential calculations makes a copy of the well-state and use that for initial guess. However, WellTesting also deals with a copy of the well-state, so when called from there we need to pass that copy as an argument (the currently used actual well-state may have nonsense values at this stage and occasionally lead to convergence issues when used as initial guess)

@steink
Copy link
Contributor Author

steink commented Jan 30, 2025

jenkins build this failure_report please

@steink steink marked this pull request as ready for review January 30, 2025 14:12
@steink steink requested a review from GitPaean January 30, 2025 14:12
Copy link
Member

@GitPaean GitPaean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution. I will merge it after another jenkins test.

@GitPaean
Copy link
Member

GitPaean commented Feb 3, 2025

jenkins build this please

@GitPaean
Copy link
Member

GitPaean commented Feb 3, 2025

the warning does not look like related to this PR,

pointer used after ‘void operator delete(void*, std::size_t)’ [-Wuse-after-free] 159 | void operator ++ () { ++ refCount(); } | ^~ In member function ‘void ALUGrid::ALUMemoryProvider::GeometryImpl<0, 0, Dune::hexa> >]’, inlined from ‘void ALUGrid::SharedPointer::removeObject() [with ObjectImp = Dune::MyALUGridGeometryImplementation<3>::GeometryImpl<0, 0, Dune::hexa>]’ at /usr/include/dune/alugrid/common/memory.hh:230:32, inlined from ‘ALUGrid::SharedPointer::~SharedPointer() [with ObjectImp = Dune::MyALUGridGeometryImplementation<3>::GeometryImpl<0, 0, Dune::hexa>]’ at /usr/include/dune/alugrid/common/memory.hh:204:19, inlined from ‘Dune::ALU3dGridGeometry<0, 3, const Dune::ALU3dGrid<3, 3, Dune::hexa, Dune::ALUGridMPIComm> >::~ALU3dGridGeometry()’ at /usr/include/dune/alugrid/3d/geometry.hh:630:9, inlined from ‘Dune::Geometry<0, 3, const Dune::ALU3dGrid<3, 3, Dune::hexa, Dune::ALUGridMPIComm>, Dune::ALU3dGridGeometry>::~Geometry()’ at /usr/include/dune/grid/common/geometry.hh:70:9, inlined from ‘Opm::FvBaseProblem::FvBaseProblem(Simulator&) [with TypeTag = Opm::Properties::TTag::FlowProblemAlugrid]’ at /var/lib/jenkins/workspace/opm-simulators-PR-builder/opm/models/discretization/common/fvbaseproblem.hh:132:89:

@akva2
Copy link
Member

akva2 commented Feb 3, 2025

it is not.

@GitPaean GitPaean merged commit 236d09c into OPM:master Feb 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants