Improve group control well counting #5932
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 7, 2025 15:48
Done by adding an argument to the recursive function.
Ensure correct count of group controlled wells, by splitting by injection phase.
atgeirr
force-pushed
the
improve-group-control-well-counting
branch
from
2280913 to
b66333d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to avoid calling the recursive (through the group subtree) groupControlledWells() function from the similarly recursive updateGroupTargetReduction() function, thereby avoiding a lot of overlap work.
The diff looks far larger than it really is, due to the reindenting of the second commit. Looking at each commit separately may be more productive.
Not at all tested yet, so opening as draft.