Added explicit default destructor for ReactionNetwork

ORNL-Fusion · Jan 22, 2025 · 5c26600 · 5c26600
1 parent efd625c
commit 5c26600
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/xolotl/core/include/xolotl/core/network/ReactionNetwork.h b/xolotl/core/include/xolotl/core/network/ReactionNetwork.h
@@ -140,6 +140,8 @@ class ReactionNetwork : public ReactionNetworkInterface<TImpl>::Type
 	ReactionNetwork(const std::vector<AmountType>& maxSpeciesAmounts,
 		IndexType gridSize, const options::IOptions& opts);
 
+	~ReactionNetwork();
+
 	KOKKOS_INLINE_FUNCTION
 	static constexpr std::size_t
 	getNumberOfSpecies() noexcept

diff --git a/xolotl/core/include/xolotl/core/network/impl/ReactionNetwork.tpp b/xolotl/core/include/xolotl/core/network/impl/ReactionNetwork.tpp
@@ -19,7 +19,7 @@ namespace network
 template <typename T>
 DualViewWrapper<T>::DualViewWrapper(const std::string& label) :
 	_dualView(Kokkos::ViewAllocateWithoutInitializing(label)),
-    _hasInstance(true),
+	_hasInstance(true),
 	d_view(_dualView.d_view),
 	h_view(_dualView.h_view)
 {
@@ -29,9 +29,9 @@ DualViewWrapper<T>::DualViewWrapper(const std::string& label) :
 template <typename T>
 DualViewWrapper<T>::~DualViewWrapper()
 {
-    if (_hasInstance) {
-        h_view().~T();
-    }
+	if (_hasInstance) {
+		h_view().~T();
+	}
 }
 
 template <typename T>
@@ -167,6 +167,11 @@ ReactionNetwork<TImpl>::ReactionNetwork(
 {
 }
 
+template <typename TImpl>
+ReactionNetwork<TImpl>::~ReactionNetwork()
+{
+}
+
 template <typename TImpl>
 const std::string&
 ReactionNetwork<TImpl>::getSpeciesLabel(SpeciesId id) const