Make energy optional #154
Merged
Make energy optional #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
streeve
commented
Nov 22, 2024
streeve
commented
- Separates output fields from those for primary updates
- Makes energy output fully optional (on by default)
- Also includes damage calculation (fused kernel with energy)
- Greatly simplifies calls to Cabana output with variadic fields
- Preparing for optional stress in Virial stress #137, blocked by this PR
streeve
force-pushed
the
optional_energy
branch
from
e004c6d
to
29137c0
Compare
abisner
reviewed
Nov 27, 2024
streeve
force-pushed
the
optional_energy
branch
from
7eecbc6
to
174de49
Compare
abisner
reviewed
Nov 27, 2024
abisner
approved these changes
Nov 27, 2024
streeve
force-pushed
the
optional_energy
branch
from
a6852aa
to
863e2e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.