Fix pbc conv args Final Draft #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RylieWeaver |
RylieWeaver
force-pushed
the
fix-pbc-conv-args--3
branch
5 times, most recently
from
001dc39
to
f8b252c
Compare
… handle edge_attr
RylieWeaver
force-pushed
the
fix-pbc-conv-args--3
branch
from
f8b252c
to
2c48245
Compare
allaffa
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pbc conv args final draft
Main points:
(1) I create edge_shifts in preprocessing with ASE, then apply those shifts in conv_args.
------The edge shifts adjust the relative vector for a connection. After additional research, I believe this to be the best way for fewer lines of code and being streamlined. It is also the approach of top competitors and does not disrupt gradient flow------
(2) Correctly applying PBC in models that update the position is currently not supported (SchNet / EGNN).
------At the core level, we have the problem that the positional update could make a node cross the supercell, even if we were to recalculate the shifts after each layer. I still allow the models to run, but simply continue to use the naive relative vectors------
(3) data.pbc is now a requirement for periodic boundary conditions
------I make an effort to include it in any examples that use PBC------
@allaffa Assuming this passes the tests I'll schedule a meeting to go over the PR.