Skip to content

Commit

Permalink
Fixed RequestTrackerService test after adding support for Job informa…
Browse files Browse the repository at this point in the history
…tion
  • Loading branch information
abujeda committed Jan 28, 2025
1 parent 6964c15 commit 72d3815
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions apps/dashboard/test/apps/request_tracker_service_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,17 @@ class RequestTrackerServiceTest < ActiveSupport::TestCase
param_hash[:Cc] == support_ticket.cc &&
param_hash[:Subject] == support_ticket.subject &&
param_hash[:Queue] == "Standard" &&
param_hash[:Priority] == "10"
param_hash[:Priority] == "10" &&
param_hash[:Text].include?('"id": "session_id"') &&
param_hash[:Text].include?('"id": "job_id"')
end
.returns("support_ticket_id")

session = BatchConnect::Session.new(id: 'session', created_at: Time.now)
session = BatchConnect::Session.new(id: 'session_id', created_at: Time.now)
job = OodCore::Job::Info.new(id: 'job_id', status: 'running')
RequestTrackerClient.stubs(:new).returns(mock_rt_client)

result = RequestTrackerService.new(config).create_ticket(support_ticket, session)
result = RequestTrackerService.new(config).create_ticket(support_ticket, session, job)

assert_equal "support_ticket_id", result
end
Expand All @@ -67,9 +70,10 @@ class RequestTrackerServiceTest < ActiveSupport::TestCase
.returns("support_ticket_id")

session = BatchConnect::Session.new(id: 'session', created_at: Time.now)
job = OodCore::Job::Info.new(id: '12345', status: 'running')
RequestTrackerClient.stubs(:new).returns(mock_rt_client)

result = RequestTrackerService.new(config).create_ticket(support_ticket, session)
result = RequestTrackerService.new(config).create_ticket(support_ticket, session, job)

assert_equal "support_ticket_id", result
end
Expand All @@ -83,8 +87,9 @@ class RequestTrackerServiceTest < ActiveSupport::TestCase
support_ticket = SupportTicket.from_config({})
support_ticket.attributes = {email: "[email protected]", cc: "[email protected]", subject: "Subject", queue: "Not_A_Queue"}
session = BatchConnect::Session.new(id: 'session', created_at: Time.now)
job = OodCore::Job::Info.new(id: '12345', status: 'running')

assert_raises(ArgumentError) { RequestTrackerService.new(config).create_ticket(support_ticket, session) }
assert_raises(ArgumentError) { RequestTrackerService.new(config).create_ticket(support_ticket, session, job) }

end
end

0 comments on commit 72d3815

Please sign in to comment.