Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed analytics.lua and resolved code dependencies #4069

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

harshit-soora
Copy link
Contributor

@harshit-soora harshit-soora commented Jan 10, 2025

To fix issue: #2808

All test are passing at forked repository.

@harshit-soora
Copy link
Contributor Author

harshit-soora commented Jan 17, 2025

Unit tests are resolved. Please approve following workflow to do a double testing, just to be sure.

Also, I have 3 commits on source, does upon merging will all the commits be automatically squashed? or should I create a single commit by resetting my changes @johrstrom?

@johrstrom
Copy link
Contributor

Also, I have 3 commits on source, does upon merging will all the commits be automatically squashed? or should I create a single commit by resetting my changes @johrstrom?

I will squash when I merge here. Or if you like you can squash if you want more control over the commit message, but I'm happy either way.

@harshit-soora
Copy link
Contributor Author

Sure if you have control over squashing then please merge the changes, I am good with it.

@johrstrom johrstrom merged commit c604ffd into OSC:master Jan 22, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants