Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] r.surf.* need seed parameter for reproducibility #1044

Open
petrasovaa opened this issue Oct 23, 2020 · 10 comments
Open

[Feat] r.surf.* need seed parameter for reproducibility #1044

petrasovaa opened this issue Oct 23, 2020 · 10 comments
Labels
C Related code is in C enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@petrasovaa
Copy link
Contributor

Modules r.surf.random, r.surf.gauss, r.surf.fractal generate different results every time you run them.
They need seed parameter for reproducible results, similarly to r.mapcalc.

@petrasovaa petrasovaa added enhancement New feature or request good first issue Good for newcomers labels Oct 23, 2020
@wenzeslaus wenzeslaus added the C Related code is in C label Jan 20, 2023
@wenzeslaus wenzeslaus added this to the 8.4.0 milestone Feb 17, 2023
@istutea
Copy link

istutea commented Feb 28, 2024

Hi @petrasovaa i'm looking forward for working on Adding JSON output project as part of GSoC ,can i work on this issue ?

@petrasovaa
Copy link
Contributor Author

Hi @petrasovaa i'm looking forward for working on Adding JSON output project as part of GSoC ,can i work on this issue ?

Welcome! Yes, I suggest to work on r.surf.fractal, look at how r.mapcalc or r.random deal with it using seed parameter and -s flag. Ideally please also include a test. Let us know if you have questions.

@Shashankss1205
Copy link

Hi @petrasovaa , I am Shashank Shekhar Singh a sophomore from IIT BHU, India. I have developed interest in this project and want to contribute to Add JSON output to different tools in C as my GSOC Project this year. Hope we can discuss further procedures for the same.

@Shashankss1205
Copy link

Hi @petrasovaa i'm looking forward for working on Adding JSON output project as part of GSoC ,can i work on this issue ?

Welcome! Yes, I suggest to work on r.surf.fractal, look at how r.mapcalc or r.random deal with it using seed parameter and -s flag. Ideally please also include a test. Let us know if you have questions.

Hi @petrasovaa, I have written the code for adding seed and -s flag for reproducibility, along with a unit test (please verify it once).
I tried sending a PR for the same, but it says Permission denied.
Screenshot from 2024-03-10 03-22-06

Can you please help me out !!

@echoix
Copy link
Member

echoix commented Mar 9, 2024

You are trying to push directly to the OSGeo/grass repo, not your fork.
Try using the little cloud with an up arrow in the bottom left corner. It should/might offer you to push that branch in your fork

@Shashankss1205
Copy link

Oh I am extremely sorry for doing this silly mistake here.
Sending a forked PR in a moment.

@kritibirda26
Copy link
Contributor

Hi @petrasovaa I intend to apply to "Adding JSON output project as part of GSoC" as well but I see a PR is already open for this issue. Should I work on this and open a PR for it anyway? Otherwise, can you please point me to another issue to work on? Thanks.

@petrasovaa
Copy link
Contributor Author

Hi @petrasovaa I intend to apply to "Adding JSON output project as part of GSoC" as well but I see a PR is already open for this issue. Should I work on this and open a PR for it anyway? Otherwise, can you please point me to another issue to work on? Thanks.

Sure. I would suggest to start working on adding JSON to one of the tools mentioned in #3020. Specifically, I suggest adding JSON to r.what. I created an issue for this: #3518, so we can discuss more there.

@Jasmitha-Mannam
Copy link

Hi...... , I want to work on this problem problem statement as a part of GSOC

@petrasovaa
Copy link
Contributor Author

Hi...... , I want to work on this problem problem statement as a part of GSOC

Hi @Jasmitha-Mannam, we currently don't have anybody else interested in the STAC idea and there are some overlaps with JSON idea, so I wonder if you would be interested in the STAC idea instead?
If yes, for a test of skills please try to work on #3537.

@wenzeslaus wenzeslaus modified the milestones: 8.4.0, Future Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C Related code is in C enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

7 participants