r.surf.gauss: Added seed option and flag #2931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I know this is a draft, but just to be clear, the compilation fails for |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
github-actions
bot
added
Python
petrasovaa
requested changes
Mar 1, 2024
github-actions
bot
added
tests
Co-authored-by: Anna Petrasova <[email protected]>
It doesn't worry that me that much. |
|
@cwhite911 see the discussion we had in #3480 (comment), we basically decided not to use the -s flag, so this PR needs to be updated... |
petrasovaa
reviewed
Mar 22, 2024
This might of been my fault. When was catching this project up I rebased and had to go back and fix the branch by resetting it to your commit then cherry-picking the work I just did. |
echoix
reviewed
Mar 24, 2024
petrasovaa
reviewed
Mar 25, 2024
petrasovaa
reviewed
Mar 25, 2024
petrasovaa
reviewed
Mar 25, 2024
Co-authored-by: Anna Petrasova <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
petrasovaa
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1044 to add seed parameter and flag for reproducible results to the r.surf.gauss module. However, tests are currently not present and should still be included.