Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Updating STRDS metadata seems unnecessarily slow #3136

Closed
ninsbl opened this issue Aug 28, 2023 · 3 comments
Closed

[Bug] Updating STRDS metadata seems unnecessarily slow #3136

ninsbl opened this issue Aug 28, 2023 · 3 comments
Labels
bug Something isn't working database Related to database management Python Related code is in Python temporal Related to temporal data processing
Milestone

Comments

@ninsbl
Copy link
Member

ninsbl commented Aug 28, 2023

Describe the bug
When I register a few new maps into an existing, larger STRDS with a couple of thousands of maps, updating metadata takes some minutes.

To Reproduce

  1. Create a larger STRS (t.create, t.register)
  2. Add a few (one or two) new maps (t.register --v)
  3. Notice the time it takes after message "Updati g metadata ..."

Expected behavior
Updating metadata when adding a few new maps should only take seconds...

System description (please complete the following information):

  • Operating System: Alpine Linux 3.18
  • GRASS GIS 8.4

Additional context
Not sure what actually causes the issue. From a first inspection it seems both the register function and the SQL templates could be improved for better performance. E.g. if min/max values of new maps are known, STRDS min/max values do not have to be re-read/computed from the map register database...

@ninsbl ninsbl added bug Something isn't working temporal Related to temporal data processing Python Related code is in Python database Related to database management backport to 8.3 labels Aug 28, 2023
@ninsbl ninsbl added this to the 8.3.1 milestone Aug 28, 2023
@neteler neteler modified the milestones: 8.3.1, 8.3.2 Oct 22, 2023
@landam
Copy link
Member

landam commented Feb 9, 2024

Both PR which are related to this issue haven't been backported to 8.3. Changing milestone to 8.4.0.

@landam landam modified the milestones: 8.3.2, 8.4.0 Feb 9, 2024
@landam
Copy link
Member

landam commented Feb 9, 2024

@ninsbl Can we close this issue?

@ninsbl
Copy link
Member Author

ninsbl commented May 19, 2024

See also: #3723
And yes, I think we can close this and ship those features with the upcoming 8.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working database Related to database management Python Related code is in Python temporal Related to temporal data processing
Projects
None yet
Development

No branches or pull requests

3 participants