temporal: use UPDATE-FROM syntax for updating metadata tables #3359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninsbl
added
enhancement
github-actions
bot
added
docs
and removed
database
echoix
reviewed
Jan 14, 2024
lib/temporal/SQL/update_stds_spatial_temporal_extent_template.sql
Outdated
Show resolved
Hide resolved
lib/temporal/SQL/update_stds_spatial_temporal_extent_template.sql
Outdated
Show resolved
Hide resolved
echoix
reviewed
Jan 14, 2024
|
Is it OK, to merge this as is, since it improves the performance noticeably? |
|
Oh, it wasn't merged yet! Of course it could be a good thing! |
Can you approve the PR? |
echoix
approved these changes
Feb 3, 2024
|
Sorry! |
jadenabrams100
pushed a commit
to ncsu-csc472-spring2024/grass-CI-playground
that referenced
this pull request
Feb 21, 2024
…3359) * use UPDATE-FROM syntax * update version_handling * integrated in main SQL update * remove table name from set and use JOIN * add FROM * NATURAL JOIN * use JOIN-ON * fix SQL syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLITE versions >= 3.30 support the UPDATE-FROM syntax. So SQL syntax in SQLITE became equal to PostgreSQL.
That means multiple columns in temporal metadata tables can now be updated from one subquery. That improves performace esp. for larger tables and simplifies the code.
Performance improvements in #3350 are more significant, though. Together with #3350 this adresses: #3136
On that occasion also the TGIS v3 related extra query for semantic labels is integrated into the main query and now gets commented out for older databases instead of running an additional query for newer databases...
Since this PR sets the minimal SQLite version to 3.30 (gets shipped e.g. with Ubuntu 20.04) I would suggest not to backport this PR...