Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxGUI/lmgr: add menu item for launching dialog for setting RStudio path #1232

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

tmszi
Copy link
Member

@tmszi tmszi commented Jan 6, 2021

Implement (fixes) issue #1171.

Set RStudio path interactively from wxGUI Layer Manager menu (dialog):

lmgr_set_rstudio_path_dialog

@tmszi tmszi added enhancement New feature or request windows Microsoft Windows specific GUI wxGUI related labels Jan 6, 2021
@wenzeslaus
Copy link
Member

+1 in general. We need some "integrated/related tools" concept in the GUI or in general. For example, we have some code for integrating with ISIS which is partially in grass.py and partially you do some manual hacking. On Windows, we try to work with R and RStudio and external Python editors with some Windows-specific scripting. ...

Looking at the new state of that menu, this PR raises priority of moving the mapset stuff out of there million times. @petrasovaa @lindakladivova

@neteler neteler added this to the 8.0.1 milestone Dec 9, 2021
@ninsbl ninsbl modified the milestones: 8.0.1, 8.2.0 Feb 20, 2022
@ninsbl
Copy link
Member

ninsbl commented Feb 20, 2022

Bumping up milestone as 8.0.1 is due in two days, while this has not been part of RC1 and there has not been activity for some time.

@wenzeslaus wenzeslaus modified the milestones: 8.2.0, 8.4.0 Mar 17, 2022
@neteler
Copy link
Member

neteler commented Feb 18, 2023

This PR needs to be rebased.

@wenzeslaus wenzeslaus modified the milestones: 8.3.0, 8.4.0 Mar 17, 2023
@hellik
Copy link
Member

hellik commented Jul 18, 2023

see also #3091 winGRASS and R integration/coupling

@neteler
Copy link
Member

neteler commented Nov 7, 2023

@tmszi Would you be willing to resolve the merge conflicts in this PR?

@github-actions github-actions bot added the Python Related code is in Python label Mar 31, 2024
gui/wxpython/core/settings.py Outdated Show resolved Hide resolved
gui/wxpython/gui_core/dialogs.py Outdated Show resolved Hide resolved
gui/wxpython/gui_core/dialogs.py Outdated Show resolved Hide resolved
gui/wxpython/gui_core/dialogs.py Outdated Show resolved Hide resolved
gui/wxpython/gui_core/dialogs.py Outdated Show resolved Hide resolved
gui/wxpython/gui_core/dialogs.py Outdated Show resolved Hide resolved
gui/wxpython/lmgr/frame.py Outdated Show resolved Hide resolved
gui/wxpython/lmgr/frame.py Outdated Show resolved Hide resolved
gui/wxpython/lmgr/frame.py Outdated Show resolved Hide resolved
gui/wxpython/lmgr/frame.py Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

(C) 2008-2016 by the GRASS Development Team
(C) 2008-2021 by the GRASS Development Team
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(C) 2008-2021 by the GRASS Development Team
(C) 2008-2024 by the GRASS Development Team

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update date range

@petrasovaa petrasovaa modified the milestones: 8.4.0, 8.4.1 May 2, 2024
@wenzeslaus wenzeslaus modified the milestones: 8.4.1, 8.5.0 Nov 5, 2024
from gui_core.widgets import SingleSymbolPanel, SimpleValidator, MapValidator
from gui_core.widgets import (
GenericValidator,
GListCtrl,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ruff] reported by reviewdog 🐶

Suggested change
GListCtrl,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GUI wxGUI related Python Related code is in Python windows Microsoft Windows specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants