-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r.univar: add JSON support #3783
Conversation
Use parson to add json output format support to the r.univar module.
Can you please compare this schema to what db.univar generates? Maybe they don't need to be the same, but if they are not, we need to have a good reason for that. |
@wenzeslaus Can you please point me to the db.univar module, I am unable to find it. |
https://github.com/OSGeo/grass/tree/f13b37931af919be04fa14f392a1f9ea9aa183fd/scripts/db.univar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update json output and tests to match v.univar
.
@cwhite911 updated. |
Co-authored-by: Nicklas Larsson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kritibirda26 nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, I haven't tested though.
* Add JSON support to r.univar Use parson to add json output format support to the r.univar module. * Apply suggestions from code review --------- Co-authored-by: Nicklas Larsson <[email protected]>
Use parson to add json output format support to the r.univar module.
Expected JSON schema:
At the root is an array, each element of which has the stats for a given zone. The percentile option allows the user to request specific percentiles which are written for each zone object as
percentile_%d
keys.