Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Fix if-expr-with-true-false (SIM210) and if-expr-with-false-true (SIM211) #3999

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

echoix
Copy link
Member

@echoix echoix commented Jul 8, 2024

Relates to pylint rule simplifiable-if-expression / R1719
Fixed ruff rules: https://docs.astral.sh/ruff/rules/if-expr-with-true-false/ and https://docs.astral.sh/ruff/rules/if-expr-with-false-true/

This is part of the effort to introduce Pylint 3.x for #3921

…ue (SIM211)

Relates to pylint rule simplifiable-if-expression / R1719
@echoix echoix added this to the 8.5.0 milestone Jul 8, 2024
@github-actions github-actions bot added GUI wxGUI related Python Related code is in Python libraries tests Related to Test Suite labels Jul 8, 2024
@echoix echoix requested a review from ninsbl July 8, 2024 21:21
Copy link
Member

@ninsbl ninsbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@echoix echoix merged commit 7b72452 into OSGeo:main Jul 9, 2024
28 checks passed
@echoix echoix deleted the fix-simplifiable-if-expression branch July 9, 2024 01:22
a0x8o pushed a commit to a0x8o/grass that referenced this pull request Jul 23, 2024
…ue (SIM211) (OSGeo#3999)

Relates to pylint rule simplifiable-if-expression / R1719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI wxGUI related libraries Python Related code is in Python tests Related to Test Suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants